Skip to content

Download and Upload Files in Parallel #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Download and Upload Files in Parallel #1376

wants to merge 5 commits into from
+92 −57

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 6, 2025 •
edited
Loading

Proposed changes

Add max_parallel_file_operations to agent config which specifies the number of file operations which will be done in parallel (Default is 5)
Files will now be uploaded and downloaded in parallel during a config apply and upload config operations.

Example of agent config

client:
    grpc:
       max_parallel_file_operations: 10

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 6, 2025
@aphralG aphralG requested a review from a team as a code owner November 6, 2025 10:28
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.29%. Comparing base (61f1fc8) to head (e1dac3c).

Files with missing lines Patch % Lines
internal/file/file_manager_service.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         102      102           
  Lines       12580    12598   +18     
=======================================
+ Hits        10856    10872   +16     
- Misses       1248     1249    +1     
- Partials      476      477    +1
Files with missing lines Coverage Δ
internal/config/config.go 87.19% <100.00%> (+0.07%) ⬆️
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 86.04% <ø> (ø)
internal/file/file_manager_service.go 75.38% <94.11%> (+0.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f1fc8...e1dac3c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dhurley
dhurley approved these changes Nov 7, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@Akshay2191 Akshay2191 Akshay2191 approved these changes

@craigell craigell craigell approved these changes

Assignees

@aphralG aphralG

Labels

chore Pull requests for routine tasks dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aphralG @dhurley @Akshay2191 @craigell